Conversation
- Add GenerativePropertiesTests.fs: 5 new tests covering instance read-only, read-write, static, multi-property name-lookup (exercises ILPropertyDefs lazy FindByName dictionary from #502), and property count on a generative type - 136/136 tests pass - Prepare RELEASE_NOTES.md for 8.6.0 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Summary
Task 9 – Testing Improvements: Add
GenerativePropertiesTests.fswith 5 new property tests for generative types.Task 10 – Take the Repository Forward: Update
RELEASE_NOTES.mdto prepare release 8.6.0.Changes
New:
tests/GenerativePropertiesTests.fsFive tests covering properties in generative type providers:
CanRead/CanWrite, non-static getterGetPropertyby name for each of the 4 properties on the generated type; directly exercises theILPropertyDefslazyFindByNamedictionary added in [Repo Assist] perf/refactor: convert ILFieldDefs/ILEventDefs/ILPropertyDefs to concrete classes with lazy name-lookup caches #502Updated:
RELEASE_NOTES.mdAdded 8.6.0 entry documenting:
ProvidedTypeDefinition.Loggercreating a new delegate reference on each call ([Repo Assist] fix: ProvidedTypeDefinition.Logger broken (new ref each call); add 5 tests for warning + enum round-trip #501)ILFieldDefs/ILEventDefs/ILPropertyDefsconcrete classes with lazy O(1) name-lookup caches ([Repo Assist] perf/refactor: convert ILFieldDefs/ILEventDefs/ILPropertyDefs to concrete classes with lazy name-lookup caches #502)Test Status
✅ 136/136 tests pass (baseline was 131; 5 new tests added, all green)